Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1014)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/config/mac/rules.gni

Issue 2564023002: Handle storyboards in GN. (Closed)
Patch Set: Add output_extension Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/mac/compile_xib.py ('k') | ios/chrome/app/resources/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/mac/rules.gni
diff --git a/build/config/mac/rules.gni b/build/config/mac/rules.gni
index f59503481f8fdc4c4000e12c53b5e322285da858..e7f1b5c425fe1eeffc03f5a599499e6908cac389 100644
--- a/build/config/mac/rules.gni
+++ b/build/config/mac/rules.gni
@@ -77,10 +77,11 @@ template("mac_xib_bundle_data") {
_target_name = target_name
_compile_target_name = _target_name + "_compile_ibtool"
- compile_xibs(_compile_target_name) {
+ compile_ib_files(_compile_target_name) {
forward_variables_from(invoker, [ "testonly" ])
visibility = [ ":$_target_name" ]
sources = invoker.sources
+ output_extension = "xib"
sdefresne 2016/12/09 17:45:41 This should be "nib".
lpromero 2016/12/09 18:04:45 Done.
ibtool_flags = [
"--minimum-deployment-target",
mac_deployment_target,
« no previous file with comments | « build/config/mac/compile_xib.py ('k') | ios/chrome/app/resources/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698