Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2563973002: Command buffer: generate appropriate error when querying IMPLEMENTATION_COLOR_READ_FORMAT/TYPE (Closed)

Created:
4 years ago by yunchao
Modified:
4 years ago
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Command buffer: generate appropriate error when querying IMPLEMENTATION_COLOR_READ_FORMAT/TYPE. When fbo incomplete, it should generate INVALID_FRAMEBUFFER_OPERATION, instead of INVALID_OPERATION. BUG=672711 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (7 generated)
yunchao
I came across crbug/672711, it seems to me that a small change can fix it. ...
4 years ago (2016-12-09 08:51:32 UTC) #4
Ken Russell (switch to Gerrit)
Sorry Yunchao but Mo found spec text that made it clear that INVALID_OPERATION is the ...
4 years ago (2016-12-13 00:14:55 UTC) #9
yunchao
4 years ago (2016-12-13 01:42:32 UTC) #10
Message was sent while issue was closed.
On 2016/12/13 00:14:55, Ken Russell wrote:
> Sorry Yunchao but Mo found spec text that made it clear that INVALID_OPERATION
> is the right error. Let's close this.

That's fine. Thanks!

Powered by Google App Engine
This is Rietveld 408576698