Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2563943002: Revert of Add test for system tray network menu icon for extension-controlled networks (Closed)

Created:
4 years ago by yhirano
Modified:
4 years ago
Reviewers:
stevenjb, James Cook
CC:
chromium-reviews, kalyank, sadrul, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add test for system tray network menu icon for extension-controlled networks (patchset #3 id:40001 of https://codereview.chromium.org/2558083003/ ) Reason for revert: NetworkingConfigDelegateChromeosTest.SystemTrayItem is failing on Linux Chromium OS ASan LSan Tests: see http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=SystemTrayItem. Original issue's description: > Add test for system tray network menu icon for extension-controlled networks > > Eventually extension-controlled network information will come out of a mojo > service. This provides test coverage to make sure the icon shows up in the > system tray menu. > > BUG=651157 > TEST=chrome browser_tests > > Committed: https://crrev.com/af700b84d792456061162fc8fdcd08065ad8773a > Cr-Commit-Position: refs/heads/master@{#437341} TBR=stevenjb@chromium.org,jamescook@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=651157 Committed: https://crrev.com/ab5d67b88547ab4b54c2d0fee2783191cb556c6d Cr-Commit-Position: refs/heads/master@{#437480}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -103 lines) Patch
M ash/common/system/networking_config_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/common/system/tray/system_tray.h View 3 chunks +0 lines, -3 lines 0 comments Download
M ash/common/system/tray/system_tray.cc View 3 chunks +1 line, -7 lines 0 comments Download
D chrome/browser/ui/ash/networking_config_delegate_chromeos_browsertest.cc View 1 chunk +0 lines, -69 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/extensions/networking_config_delegate/background.js View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/test/data/extensions/networking_config_delegate/manifest.json View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
yhirano
Created Revert of Add test for system tray network menu icon for extension-controlled networks
4 years ago (2016-12-09 05:48:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563943002/1
4 years ago (2016-12-09 05:49:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 05:50:18 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-09 05:52:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab5d67b88547ab4b54c2d0fee2783191cb556c6d
Cr-Commit-Position: refs/heads/master@{#437480}

Powered by Google App Engine
This is Rietveld 408576698