Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: third_party/WebKit/Source/core/css/CSSProperties.in

Issue 2563913002: Added functionality in ComputedStyleBase to use platform/ types (Closed)
Patch Set: Rebase Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/CSSProperties.in
diff --git a/third_party/WebKit/Source/core/css/CSSProperties.in b/third_party/WebKit/Source/core/css/CSSProperties.in
index 5a30f1d12c91ff5829f49551efb436e9ff33374d..08076e6786e4686061d6e01d8ef2b8eb255a9f29 100644
--- a/third_party/WebKit/Source/core/css/CSSProperties.in
+++ b/third_party/WebKit/Source/core/css/CSSProperties.in
@@ -40,10 +40,21 @@
// generating the ComputedStyle storage for the property. The initial
// value for this property on a ComputedStyle is specified with the
// initial_keyword flag below.
+// TODO(sashab): Rename this to field_type=keyword once we support
+// multiple types of generatable fields in ComputedStyle
// TODO(sashab, meade): Remove this once TypedOM types are specified for
// every property, since this value can be inferred from that.
+// - field_storage_type=path/to/Type
+// For properties that have generated field storage in ComputedStyle,
+// this optional argument will override the field's generated type with
+// an external one specified at the given path. The type must be defined
+// in a header file at that path, and have the same name as the file.
+// Currently, only enum types are supported, and the enum's only values
+// must be CamelCase values of the keywords of the property.
+
+
// - keywords=[keyword1|keyword2]
// This specifies all valid keyword values for the property.
// TODO(sashab): Once all properties are represented here, delete
@@ -151,7 +162,7 @@ transition-timing-function custom_all
// High Priority and all other font properties.
// Other properties can depend upon high priority properties (e.g. font-size / ems)
color interpolable, inherited, custom_all
-direction inherited, custom_value
+direction inherited, custom_value, keyword_only, keywords=[ltr|rtl], initial_keyword=ltr, field_storage_type=platform/text/TextDirection
font-family inherited, font, type_name=FontDescription::FamilyDescription, name_for_methods=FamilyDescription, converter=convertFontFamily
font-kerning inherited, font, type_name=FontDescription::Kerning, name_for_methods=Kerning
font-size interpolable, inherited, font, name_for_methods=Size, getter=getSize, converter=convertFontSize

Powered by Google App Engine
This is Rietveld 408576698