Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7535)

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm

Issue 2563863003: [Autofill] Remove AutofillPopupController::IsWarning() (Closed)
Patch Set: fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/autofill/autofill_popup_base_view_cocoa.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm b/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm
index c21981d1a83148c414ad13483af997296d8d6fac..f45e014f0bd4641023ccd98f43feef2ca7dd6992 100644
--- a/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm
+++ b/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm
@@ -197,11 +197,8 @@ - (CGFloat)drawName:(NSString*)name
rightAlign:(BOOL)rightAlign
bounds:(NSRect)bounds
textYOffset:(CGFloat)textYOffset {
- // TODO(crbug.com/666189): Use
- // AutofillPopupLayoutModel::GetValueFontColorForRow() instead and remove
- // IsWarning() method.
- NSColor* nameColor =
- controller_->IsWarning(index) ? [self warningColor] : [self nameColor];
+ NSColor* nameColor = skia::SkColorToSRGBNSColor(
+ controller_->layout_model().GetValueFontColorForRow(index));
NSDictionary* nameAttributes = [NSDictionary
dictionaryWithObjectsAndKeys:controller_->layout_model()
.GetValueFontListForRow(index)
« no previous file with comments | « chrome/browser/ui/cocoa/autofill/autofill_popup_base_view_cocoa.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698