[Autofill] Remove AutofillPopupController::IsWarning()

chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.h"
 
 #include "base/logging.h"
 #include "base/strings/sys_string_conversions.h"
 #include "chrome/browser/ui/autofill/autofill_popup_controller.h"
 #include "chrome/browser/ui/autofill/autofill_popup_layout_model.h"
 #include "chrome/browser/ui/autofill/popup_constants.h"
 #include "chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.h"
 #include "components/autofill/core/browser/popup_item_ids.h"
 #include "components/autofill/core/browser/suggestion.h"
 #include "skia/ext/skia_utils_mac.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "ui/base/cocoa/window_size_constants.h"
 #include "ui/base/resource/resource_bundle.h"
+#include "ui/gfx/color_palette.h"

[Robert Sesek, 2016/12/14 20:14:21]

Unused include?

 #include "ui/gfx/font_list.h"
 #include "ui/gfx/geometry/point.h"
 #include "ui/gfx/geometry/rect.h"
 #include "ui/gfx/image/image.h"
 
 using autofill::AutofillPopupView;
 using autofill::AutofillPopupLayoutModel;
 
 @interface AutofillPopupViewCocoa ()
 
@@ skipping 161 matching lines @@
              bounds:bounds
         textYOffset:textYOffset];
 }
 
 - (CGFloat)drawName:(NSString*)name
                 atX:(CGFloat)x
               index:(size_t)index
          rightAlign:(BOOL)rightAlign
              bounds:(NSRect)bounds
         textYOffset:(CGFloat)textYOffset {
-  // TODO(crbug.com/666189): Use
-  // AutofillPopupLayoutModel::GetValueFontColorForRow() instead and remove
-  // IsWarning() method.
-  NSColor* nameColor =
-      controller_->IsWarning(index) ? [self warningColor] : [self nameColor];
+  SkColor skColor = controller_->layout_model().GetValueFontColorForRow(index);
+  NSColor* nameColor = skia::SkColorToSRGBNSColor(skColor);

[Robert Sesek, 2016/12/14 20:14:21]

Since skColor is only used here you could just do:
skia::SkColorToSRGBNSColor(controller_->layout_model().GetValueFontColorForRow(index));

   NSDictionary* nameAttributes = [NSDictionary
       dictionaryWithObjectsAndKeys:controller_->layout_model()
                                        .GetValueFontListForRow(index)
                                        .GetPrimaryFont()
                                        .GetNativeFont(),
                                    NSFontAttributeName, nameColor,
                                    NSForegroundColorAttributeName, nil];
   NSSize nameSize = [name sizeWithAttributes:nameAttributes];
   x -= rightAlign ? nameSize.width : 0;
   CGFloat y = bounds.origin.y + (bounds.size.height - nameSize.height) / 2;
@@ skipping 56 matching lines @@
     return nil;
 
   int iconId = delegate_->GetIconResourceID(icon);
   DCHECK_NE(-1, iconId);
 
   ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
   return rb.GetNativeImageNamed(iconId).ToNSImage();
 }
 
 @end