third_party/WebKit/Source/core/html/shadow/MediaControls.cpp - Issue 2563853003: [MediaControls] Listen to durationchange instead of letting HTML call methods of MediaControls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

Issue 2563853003: [MediaControls] Listen to durationchange instead of letting HTML call methods of MediaControls (Closed)

Patch Set: addressed nits from mlamouri@ Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

index c7685babd45c0dc954c0a852c454b8367de70065..daade53bb3b95adf43a7c2788d7c3a2bff1790b9 100644

--- a/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

@@ -705,6 +705,11 @@ void MediaControls::onTimeUpdate() {

makeTransparent();

}

+void MediaControls::onDurationChange() {

+ m_timeline->setDuration(mediaElement().duration());

+ updateCurrentTimeDisplay();

void MediaControls::onPlay() {

updatePlayState();

m_timeline->setPosition(mediaElement().currentTime());