Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: third_party/WebKit/Source/core/html/shadow/MediaControls.h

Issue 2563853003: [MediaControls] Listen to durationchange instead of letting HTML call methods of MediaControls (Closed)
Patch Set: addressed nits from mlamouri@ Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 3 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 // Node 146 // Node
147 bool isMediaControls() const override { return true; } 147 bool isMediaControls() const override { return true; }
148 bool willRespondToMouseMoveEvents() override { return true; } 148 bool willRespondToMouseMoveEvents() override { return true; }
149 void defaultEventHandler(Event*) override; 149 void defaultEventHandler(Event*) override;
150 bool containsRelatedTarget(Event*); 150 bool containsRelatedTarget(Event*);
151 151
152 // Methods called by MediaControlsMediaEventListener. 152 // Methods called by MediaControlsMediaEventListener.
153 void onVolumeChange(); 153 void onVolumeChange();
154 void onFocusIn(); 154 void onFocusIn();
155 void onTimeUpdate(); 155 void onTimeUpdate();
156 void onDurationChange();
156 void onPlay(); 157 void onPlay();
157 void onPause(); 158 void onPause();
158 void onTextTracksAddedOrRemoved(); 159 void onTextTracksAddedOrRemoved();
159 void onTextTracksChanged(); 160 void onTextTracksChanged();
160 161
161 Member<HTMLMediaElement> m_mediaElement; 162 Member<HTMLMediaElement> m_mediaElement;
162 163
163 // Media control elements. 164 // Media control elements.
164 Member<MediaControlOverlayEnclosureElement> m_overlayEnclosure; 165 Member<MediaControlOverlayEnclosureElement> m_overlayEnclosure;
165 Member<MediaControlOverlayPlayButtonElement> m_overlayPlayButton; 166 Member<MediaControlOverlayPlayButtonElement> m_overlayPlayButton;
(...skipping 28 matching lines...) Expand all
194 int m_panelWidth; 195 int m_panelWidth;
195 196
196 bool m_keepShowingUntilTimerFires : 1; 197 bool m_keepShowingUntilTimerFires : 1;
197 }; 198 };
198 199
199 DEFINE_ELEMENT_TYPE_CASTS(MediaControls, isMediaControls()); 200 DEFINE_ELEMENT_TYPE_CASTS(MediaControls, isMediaControls());
200 201
201 } // namespace blink 202 } // namespace blink
202 203
203 #endif 204 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.cpp ('k') | third_party/WebKit/Source/core/html/shadow/MediaControls.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698