chrome/common/extensions/manifest_tests/extension_manifests_sandboxed_unittest.cc - Issue 2563843002: Restrict app sandbox's CSP to disallow loading web content in them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_sandboxed_unittest.cc

Issue 2563843002: Restrict app sandbox's CSP to disallow loading web content in them. (Closed)

Patch Set: address comments + rework CL + StringPieces Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/sandboxed_pages_apitest.cc ('k') | chrome/test/data/extensions/api_test/sandboxed_pages_csp/local_frame.html » ('j') | chrome/test/data/extensions/api_test/sandboxed_pages_csp/sandboxed.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_sandboxed_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_sandboxed_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_sandboxed_unittest.cc

index 1c8e0ce9ef48c1841a2cfb6db2fc088a8afd2677..708dfc09e4d6139e4ecac63dda662bf8ff7ed980 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_sandboxed_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_sandboxed_unittest.cc

@@ -37,12 +37,13 @@ TEST_F(SandboxedPagesManifestTest, SandboxedPages) {

LoadAndExpectSuccess("sandboxed_pages_valid_5.json"));

const char kSandboxedCSP[] =

- "sandbox allow-scripts allow-forms allow-popups allow-modals";

+ "sandbox allow-scripts allow-forms allow-popups allow-modals; "

+ "script-src 'self' 'unsafe-inline' 'unsafe-eval'; child-src 'self';";

const char kDefaultCSP[] =

"script-src 'self' blob: filesystem: chrome-extension-resource:; "

"object-src 'self' blob: filesystem:;";

const char kCustomSandboxedCSP[] =

- "sandbox; script-src: https://www.google.com";

+ "sandbox; script-src 'self'; child-src 'self';";

EXPECT_EQ(

kSandboxedCSP,