Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2563823002: wptserve: Import latest version of wpt-tools. (Closed)

Created:
4 years ago by Marijn Kruisselbrink
Modified:
4 years ago
Reviewers:
tkent, jsbell, qyearsley
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

wptserve: Import latest version of wpt-tools. This revision contains a fix to the "bind_hostname" functionality that makes it possible to use that, rather than incorrectly overriding the "host" config to an ip-address. This fixes {{host}} and things like {{domains[www]}} substitutions for tests when run with wptserve. BUG=618616 Committed: https://crrev.com/53f836a77403eebfca81a619ed33c3b1db274b1c Cr-Commit-Position: refs/heads/master@{#437430}

Patch Set 1 #

Messages

Total messages: 16 (9 generated)
Marijn Kruisselbrink
No idea if this is the correct way to update our copy of wpt-tools (do ...
4 years ago (2016-12-08 23:41:51 UTC) #5
qyearsley
On 2016/12/08 at 23:41:51, mek wrote: > No idea if this is the correct way ...
4 years ago (2016-12-09 00:41:31 UTC) #8
tkent
lgtm
4 years ago (2016-12-09 00:58:40 UTC) #9
Marijn Kruisselbrink
On 2016/12/09 at 00:41:31, qyearsley wrote: > On 2016/12/08 at 23:41:51, mek wrote: > > ...
4 years ago (2016-12-09 01:53:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563823002/1
4 years ago (2016-12-09 01:53:38 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 02:15:51 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-09 02:19:28 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53f836a77403eebfca81a619ed33c3b1db274b1c
Cr-Commit-Position: refs/heads/master@{#437430}

Powered by Google App Engine
This is Rietveld 408576698