Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1302)

Unified Diff: sync/engine/get_commit_ids.h

Issue 25638003: sync: Implement per-type commit interface (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Attempt to fix win compile Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/engine/commit_util.cc ('k') | sync/engine/get_commit_ids.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/engine/get_commit_ids.h
diff --git a/sync/engine/get_commit_ids.h b/sync/engine/get_commit_ids.h
index 557853f36dff36340e34c9b17dfdde37c29c3ac0..b435848e3495970b26b80530853a68b8d69a88af 100644
--- a/sync/engine/get_commit_ids.h
+++ b/sync/engine/get_commit_ids.h
@@ -15,15 +15,14 @@ using std::vector;
namespace syncer {
-namespace sessions {
-class OrderedCommitSet;
-}
-
namespace syncable {
class BaseTransaction;
}
-// These functions return handles in "commit order". A valid commit ordering is
+// Returns up to |max_entries| metahandles of entries that belong to the
+// specified |type| and are ready for commit.
+//
+// This function returns handles in "commit order". A valid commit ordering is
// one where parents are placed before children, predecessors are placed before
// successors, and deletes appear after creates and moves.
//
@@ -32,25 +31,12 @@ class BaseTransaction;
// system can handle receiving the elements within a folder out of order, so we
// may be able to remove that functionality in the future.
// See crbug.com/287938.
-
-// Returns up to |max_entries| metahandles of entries that belong to the
-// specified |type| and are ready for commit. The returned handles will be
-// in a valid commit ordering.
SYNC_EXPORT_PRIVATE void GetCommitIdsForType(
syncable::BaseTransaction* trans,
ModelType type,
size_t max_entries,
std::vector<int64>* out);
-// Fills the specified |ordered_commit_set| with up to |commit_batch_size|
-// metahandles that belong to the set of types |requested_types| and are ready
-// for commit. The list will be in a valid commit ordering.
-SYNC_EXPORT_PRIVATE void GetCommitIds(
- syncable::BaseTransaction* trans,
- ModelTypeSet requested_types,
- size_t commit_batch_size,
- sessions::OrderedCommitSet* ordered_commit_set);
-
} // namespace syncer
#endif // SYNC_ENGINE_GET_COMMIT_IDS_H_
« no previous file with comments | « sync/engine/commit_util.cc ('k') | sync/engine/get_commit_ids.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698