sync: Implement per-type commit interface

sync/engine/get_commit_ids.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/engine/get_commit_ids.h"
 
 #include <set>
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 32 matching lines @@
 //
 // See the header file for an explanation of commit ordering.
 void OrderCommitIds(
     syncable::BaseTransaction* trans,
     size_t max_entries,
     const std::set<int64>& ready_unsynced_set,
     std::vector<int64>* out);
 
 }  // namespace
 
 void GetCommitIdsForType(

[Nicolas Zea, 2013/10/09 00:17:39]

why not just have this at the bottom of the file now, so you don't have to
forward declare functions, and so you don't have multiple anon namespaces within
the file?

[rlarocque, 2013/10/09 20:00:19]

This is also intended to avoid unnecessary diffs.

     syncable::BaseTransaction* trans,
     ModelType type,
     size_t max_entries,
     syncable::Directory::Metahandles* out) {
   syncable::Directory* dir = trans->directory();
 
   // Gather the full set of unsynced items and store it in the session. They
   // are not in the correct order for commit.
   std::set<int64> ready_unsynced_set;
   syncable::Directory::Metahandles all_unsynced_handles;
@@ skipping 435 matching lines @@
 
   // Add moves and creates, and prepend their uncommitted parents.
   traversal.AddCreatesAndMoves(ready_unsynced_set);
 
   // Add all deletes.
   traversal.AddDeletes(ready_unsynced_set);
 }
 
 }  // namespace
 
-void GetCommitIds(
-    syncable::BaseTransaction* trans,
-    ModelTypeSet requested_types,
-    size_t commit_batch_size,
-    sessions::OrderedCommitSet* ordered_commit_set) {
-  for (ModelTypeSet::Iterator it = requested_types.First();
-       it.Good(); it.Inc()) {
-    DCHECK_LE(ordered_commit_set->Size(), commit_batch_size);
-    if (ordered_commit_set->Size() >= commit_batch_size)
-      break;
-    size_t space_remaining = commit_batch_size - ordered_commit_set->Size();
-    syncable::Directory::Metahandles out;
-    GetCommitIdsForType(
-        trans,
-        it.Get(),
-        space_remaining,
-        &out);
-    ordered_commit_set->AddCommitItems(out, it.Get());
-  }
-}
-
 }  // namespace syncer