Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2563783003: Avoid division-by-zero when visual viewport width is 0. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index fc8f37723622c32a6de17ab60b65e731e45b1271..21257bd9015ef7bcaa7b7126d3c7314f91ccb3ce 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -1353,7 +1353,8 @@ FloatSize FrameView::viewportSizeForViewportUnits() const {
// height, compensating for page scale as well, since we want to use the
// viewport with browser controls hidden for vh (to match Safari).
BrowserControls& browserControls = m_frame->host()->browserControls();
- if (m_frame->isMainFrame() && size.width()) {
+ if (m_frame->isMainFrame() && size.width() &&
+ m_frame->host()->visualViewport().size().width()) {
rune 2016/12/09 15:27:50 I should probably check the pageScaleAtLayoutWidth
bokan 2016/12/09 16:48:55 Visual Viewport size should never be 0, do you kno
float pageScaleAtLayoutWidth =
m_frame->host()->visualViewport().size().width() / size.width();
size.expand(0, browserControls.height() / pageScaleAtLayoutWidth);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698