Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: components/exo/surface.cc

Issue 2563783002: ui + mus: Split ContextFactory into ContextFactory(Client) and ContextFactoryPrivate (Closed)
Patch Set: Restore mash Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/view_event_test_platform_part_default.cc ('k') | components/exo/surface_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/exo/surface.cc
diff --git a/components/exo/surface.cc b/components/exo/surface.cc
index f295aaa46096e5edef0e3a5c9121a23820f4fdb3..6635a198730415205fcd6b1d3c8202a71a032260 100644
--- a/components/exo/surface.cc
+++ b/components/exo/surface.cc
@@ -144,16 +144,21 @@ class CustomWindowTargeter : public aura::WindowTargeter {
////////////////////////////////////////////////////////////////////////////////
// Surface, public:
+// TODO(fsamuel): exo should not use context_factory_private. Instead, we should
+// request a CompositorFrameSink from the aura::Window. Setting up the
+// BeginFrame hierarchy should be an internal implementation detail of aura or
+// mus in aura-mus.
Surface::Surface()
: window_(new aura::Window(new CustomWindowDelegate(this))),
- frame_sink_id_(
- aura::Env::GetInstance()->context_factory()->AllocateFrameSinkId()) {
+ frame_sink_id_(aura::Env::GetInstance()
+ ->context_factory_private()
+ ->AllocateFrameSinkId()) {
cc::mojom::MojoCompositorFrameSinkClientPtr frame_sink_holder_ptr;
cc::mojom::MojoCompositorFrameSinkClientRequest frame_sink_client_request =
mojo::GetProxy(&frame_sink_holder_ptr);
std::unique_ptr<CompositorFrameSink> frame_sink(new CompositorFrameSink(
frame_sink_id_,
- aura::Env::GetInstance()->context_factory()->GetSurfaceManager(),
+ aura::Env::GetInstance()->context_factory_private()->GetSurfaceManager(),
std::move(frame_sink_holder_ptr)));
compositor_frame_sink_holder_ = new CompositorFrameSinkHolder(
this, std::move(frame_sink), std::move(frame_sink_client_request));
« no previous file with comments | « chrome/test/base/view_event_test_platform_part_default.cc ('k') | components/exo/surface_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698