ui + mus: Split ContextFactory into ContextFactory(Client) and ContextFactoryPrivate

mash/test/mash_test_suite.cc

Index: mash/test/mash_test_suite.cc
diff --git a/mash/test/mash_test_suite.cc b/mash/test/mash_test_suite.cc
index 15715683b4170ee52dcb5d3a391cb597abe6bf61..5d42365d15815067a4811f037af1452926b7dce1 100644
--- a/mash/test/mash_test_suite.cc
+++ b/mash/test/mash_test_suite.cc
@@ -32,8 +32,14 @@ void MashTestSuite::Initialize() {
   env_ = aura::Env::CreateInstance(aura::Env::Mode::MUS);
   gl::GLSurfaceTestSupport::InitializeOneOff();
   const bool enable_pixel_output = false;
-  env_->set_context_factory(
-      ui::InitializeContextFactoryForTests(enable_pixel_output));
+
+  ui::ContextFactory* context_factory = nullptr;
+  ui::ContextFactoryPrivate* context_factory_private = nullptr;
+  ui::InitializeContextFactoryForTests(enable_pixel_output, &context_factory,
+                                       &context_factory_private);
+
+  env_->set_context_factory(context_factory);
+  env_->set_context_factory_private(context_factory_private);

[rjkroege, 2016/12/14 00:15:31]

Why is this necessary? This is mash code. It's a client and so shouldn't require
this?

[Fady Samuel, 2016/12/14 01:27:12]

I don't think it's necessary. Removed.

[Fady Samuel, 2016/12/14 04:51:02]

I don't understand what's going on...

It seems like mash_unittests is using InProcessContextFactory and not Mus or
SurfaceContextFactory...I need to investigate further...filing a bug.

 }
 
 void MashTestSuite::Shutdown() {