third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/FileCheckerCallable.java - Issue 2563763003: DevTools: roll closure compiler to 20161201.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/FileCheckerCallable.java

Issue 2563763003: DevTools: roll closure compiler to 20161201. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/scripts/compile_frontend.py ('K') | « third_party/WebKit/Source/devtools/scripts/jsdoc_validator/jsdoc_validator.jar ('k') | third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/checks/AstUtil.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/FileCheckerCallable.java

diff --git a/third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/FileCheckerCallable.java b/third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/FileCheckerCallable.java

index 93d76372c54c3e744b7a1a9ae6a7973d1bfdeaa1..1f261eb84174fef0c0b4d21ba92433b92ad39272 100644

--- a/third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/FileCheckerCallable.java

+++ b/third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/FileCheckerCallable.java

@@ -3,7 +3,10 @@ package org.chromium.devtools.jsdoc;

import com.google.javascript.jscomp.Compiler;

import com.google.javascript.jscomp.NodeTraversal;

import com.google.javascript.jscomp.parsing.Config;

+import com.google.javascript.jscomp.parsing.Config.JsDocParsing;

import com.google.javascript.jscomp.parsing.Config.LanguageMode;

+import com.google.javascript.jscomp.parsing.Config.StrictMode;

+import com.google.javascript.jscomp.parsing.Config.RunMode;

import com.google.javascript.jscomp.parsing.ParserRunner;

import com.google.javascript.rhino.ErrorReporter;

import com.google.javascript.rhino.Node;

@@ -55,8 +58,9 @@ public class FileCheckerCallable implements Callable<ValidatorContext> {

}

private static Node parseScript(final ValidatorContext context) {

- Config config = ParserRunner.createConfig(

- true, true, true, LanguageMode.ECMASCRIPT5_STRICT, EXTRA_ANNOTATIONS);

+ Config config = ParserRunner.createConfig(LanguageMode.ECMASCRIPT6,

+ JsDocParsing.INCLUDE_DESCRIPTIONS_WITH_WHITESPACE, RunMode.KEEP_GOING,

+ EXTRA_ANNOTATIONS, true, StrictMode.STRICT);

ErrorReporter errorReporter = new ErrorReporter() {

@Override

public void warning(String message, String sourceName, int line, int lineOffset) {