Issue 2563723003: Revert "Let `Isolate.errors` close on isolate exit."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2563723003: Revert "Let `Isolate.errors` close on isolate exit." (Closed)

Created:
4 years ago by Lasse Reichstein Nielsen

Modified:
4 years ago

Reviewers:

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Let `Isolate.errors` close on isolate exit." This reverts commit aeb544351e2d80f2a45c6910a29dd9a87d79bf2c. Wasn't ready for landing yet, and triggers bug in VM. Committed: https://github.com/dart-lang/sdk/commit/283bba09444af346c12608d7ab1b16dc9648bf95

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -111 lines)			Patch
	M	sdk/lib/isolate/isolate.dart	View		1 chunk	+5 lines, -20 lines	0 comments	Download
	D	tests/isolate/isolate_errors_test.dart	View		1 chunk	+0 lines, -91 lines	0 comments	Download

Total messages: 2 (1 generated)

Lasse Reichstein Nielsen

4 years ago (2016-12-09 12:02:24 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
283bba09444af346c12608d7ab1b16dc9648bf95 (presubmit successful).