Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 25637003: Fix cq compilation error on win_x64 (Closed)

Created:
7 years, 2 months ago by Alpha Left Google
Modified:
7 years, 2 months ago
Reviewers:
Zhenyao Mo, pwestin
CC:
chromium-reviews, feature-media-reviews_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Fix cq compilation error on win_x64 My last change to fix cq compilation error introduced a bug in code. Fixed in this change. R=pwestin@google.com TBR=zmo@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226348

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/cast/rtcp/rtcp_sender.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Alpha Left Google
7 years, 2 months ago (2013-10-01 23:45:24 UTC) #1
pwestin
lgtm
7 years, 2 months ago (2013-10-01 23:48:56 UTC) #2
Alpha Left Google
Committed patchset #1 manually as r226348 (presubmit successful).
7 years, 2 months ago (2013-10-01 23:51:55 UTC) #3
Evan Stade
On 2013/10/01 23:51:55, Alpha wrote: > Committed patchset #1 manually as r226348 (presubmit successful). Still ...
7 years, 2 months ago (2013-10-02 00:40:38 UTC) #4
Alpha Left Google
On 2013/10/02 00:40:38, Evan Stade wrote: > On 2013/10/01 23:51:55, Alpha wrote: > > Committed ...
7 years, 2 months ago (2013-10-02 00:49:28 UTC) #5
Alpha Left Google
7 years, 2 months ago (2013-10-02 00:49:49 UTC) #6
Message was sent while issue was closed.
On 2013/10/02 00:49:28, Alpha wrote:
> On 2013/10/02 00:40:38, Evan Stade wrote:
> > On 2013/10/01 23:51:55, Alpha wrote:
> > > Committed patchset #1 manually as r226348 (presubmit successful).
> > 
> > Still getting some errors:
> >
>
http://build.chromium.org/p/tryserver.chromium/builders/win_x64_rel/builds/42...
> 
> Cast targets are removed so this won't be a problem.

That's r226370.

Powered by Google App Engine
This is Rietveld 408576698