Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Issue 2563693003: Remove unused list data pointer (Closed)

Created:
4 years ago by dsinclair
Modified:
4 years ago
Reviewers:
Tom Sepez, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove unused list data pointer The list item data pointer was never assigned. Removed pointer and referencing code. Committed: https://pdfium.googlesource.com/pdfium/+/53ed03d9d865c312fdaa4434b83ed60619881226

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M xfa/fwl/cfwl_combobox.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M xfa/fwl/cfwl_listbox.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/cfwl_listbox.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M xfa/fwl/cfwl_listitem.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/cfwl_listitem.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
dsinclair
PTAL.
4 years ago (2016-12-08 20:19:32 UTC) #2
Tom Sepez
lgtm
4 years ago (2016-12-08 20:27:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563693003/1
4 years ago (2016-12-08 20:31:09 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-08 20:37:57 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/53ed03d9d865c312fdaa4434b83ed6061988...

Powered by Google App Engine
This is Rietveld 408576698