src/messages.cc - Issue 2563673002: [wasm] Generate correct locations for error messages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/messages.cc

Issue 2563673002: [wasm] Generate correct locations for error messages (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/messages.cc

diff --git a/src/messages.cc b/src/messages.cc

index 1cb455efb56bcddc01576054648af72c20c13328..443399c8a078cad1c6c36824fd3581a8efd3a11a 100644

--- a/src/messages.cc

+++ b/src/messages.cc

@@ -673,6 +673,7 @@ MaybeHandle<String> WasmStackFrame::ToString() {

}

int WasmStackFrame::GetPosition() const {

+ // TODO(wasm): Clean this up (bug 5007).

return (offset_ < 0) ? (-1 - offset_) : code_->SourcePosition(offset_);

}

« src/d8.cc ('K') | « src/isolate.cc ('k') | test/message/wasm-trap.js » ('j') | no next file with comments »