Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(17)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: test/message/wasm-trap.out
Issue
2563673002
:
[wasm] Generate correct locations for error messages (Closed)
Patch Set:
Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
include/v8.h
src/api.cc
src/d8.h
src/d8.cc
src/isolate.cc
src/messages.cc
test/message/wasm-trap.js
test/message/wasm-trap.out
View unified diff
|
Download patch
« src/d8.cc
('K') |
« test/message/wasm-trap.js
('k') |
no next file »
|
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<WASM>[0]+5: RuntimeError: divide by zero
2
RuntimeError: divide by zero
3
at main (<WASM>[0]+5)
4
at *%(basename)s:15:16
5
OLD
NEW
« src/d8.cc
('K') |
« test/message/wasm-trap.js
('k') |
no next file »
|
no next file with comments »
Issue 2563673002: [wasm] Generate correct locations for error messages (Closed)
Created 4 years ago by Clemens Hammacher
Modified 4 years ago
Reviewers: titzer, Yang
Base URL:
Comments: 1
This is Rietveld
408576698