Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2563663003:
Remove -r option from dump_syms invocation on Linux (Closed)
|
Created:
4 years ago by scottmg Modified:
4 years ago Reviewers:
Mark Mentovai CC:
chromium-reviews, Lei Zhang Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove -r option from dump_syms invocation on Linux
The -r option was originally added and used to attempt to avoid address
space exhaustion on 32 bit builders. It appears to be causing missing
function names in stack traces (see https://crbug.com/670533). Since we
no longer build on 32 bit anyway, remove the option.
R=mark@chromium.org
BUG=670533, 230995
Committed: https://crrev.com/fc57756e6a469a6f2df99a0b9cd0dd40f9f6b8f4
Cr-Commit-Position: refs/heads/master@{#437277}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 15 (9 generated)
Description was changed from ========== Remove -r option from dump_syms invocation on Linux The -r option was originally added and used to attempt to avoid address space exhaustion on 32 bit builders. It appears to be causing missing function names in stack traces (see http:s//crbug.com/670533). Since we no longer build on 32 bit anyway, remove the option. R=mark@chromium.org BUG=670533,230995 ========== to ========== Remove -r option from dump_syms invocation on Linux The -r option was originally added and used to attempt to avoid address space exhaustion on 32 bit builders. It appears to be causing missing function names in stack traces (see http:s//crbug.com/670533). Since we no longer build on 32 bit anyway, remove the option. R=mark@chromium.org BUG=670533,230995 ==========
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM https://codereview.chromium.org/2563663003/diff/1/build/linux/dump_app_syms.py File build/linux/dump_app_syms.py (right): https://codereview.chromium.org/2563663003/diff/1/build/linux/dump_app_syms.p... build/linux/dump_app_syms.py:1: # Copyright 2015 The Chromium Authors. All rights reserved. In the change description: see http:s//crbug.com/670533 - fix URL
Description was changed from ========== Remove -r option from dump_syms invocation on Linux The -r option was originally added and used to attempt to avoid address space exhaustion on 32 bit builders. It appears to be causing missing function names in stack traces (see http:s//crbug.com/670533). Since we no longer build on 32 bit anyway, remove the option. R=mark@chromium.org BUG=670533,230995 ========== to ========== Remove -r option from dump_syms invocation on Linux The -r option was originally added and used to attempt to avoid address space exhaustion on 32 bit builders. It appears to be causing missing function names in stack traces (see https://crbug.com/670533). Since we no longer build on 32 bit anyway, remove the option. R=mark@chromium.org BUG=670533,230995 ==========
On 2016/12/08 17:35:03, Mark Mentovai wrote: > LGTM > > https://codereview.chromium.org/2563663003/diff/1/build/linux/dump_app_syms.py > File build/linux/dump_app_syms.py (right): > > https://codereview.chromium.org/2563663003/diff/1/build/linux/dump_app_syms.p... > build/linux/dump_app_syms.py:1: # Copyright 2015 The Chromium Authors. All > rights reserved. > In the change description: > > see http:s//crbug.com/670533 - fix URL Oops, done.
The CQ bit was unchecked by scottmg@chromium.org
The CQ bit was checked by scottmg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481218592243530, "parent_rev":
"15f49d5afabcbbd98c3812bf9a3f968406a88d27", "commit_rev":
"4e6385a40932c5c169103f649e29546800db1139"}
Message was sent while issue was closed.
Description was changed from ========== Remove -r option from dump_syms invocation on Linux The -r option was originally added and used to attempt to avoid address space exhaustion on 32 bit builders. It appears to be causing missing function names in stack traces (see https://crbug.com/670533). Since we no longer build on 32 bit anyway, remove the option. R=mark@chromium.org BUG=670533,230995 ========== to ========== Remove -r option from dump_syms invocation on Linux The -r option was originally added and used to attempt to avoid address space exhaustion on 32 bit builders. It appears to be causing missing function names in stack traces (see https://crbug.com/670533). Since we no longer build on 32 bit anyway, remove the option. R=mark@chromium.org BUG=670533,230995 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove -r option from dump_syms invocation on Linux The -r option was originally added and used to attempt to avoid address space exhaustion on 32 bit builders. It appears to be causing missing function names in stack traces (see https://crbug.com/670533). Since we no longer build on 32 bit anyway, remove the option. R=mark@chromium.org BUG=670533,230995 ========== to ========== Remove -r option from dump_syms invocation on Linux The -r option was originally added and used to attempt to avoid address space exhaustion on 32 bit builders. It appears to be causing missing function names in stack traces (see https://crbug.com/670533). Since we no longer build on 32 bit anyway, remove the option. R=mark@chromium.org BUG=670533,230995 Committed: https://crrev.com/fc57756e6a469a6f2df99a0b9cd0dd40f9f6b8f4 Cr-Commit-Position: refs/heads/master@{#437277} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/fc57756e6a469a6f2df99a0b9cd0dd40f9f6b8f4 Cr-Commit-Position: refs/heads/master@{#437277} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
