Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 2563613002: Unify "contributes to" and "requires mask" for clip-path child iteration (Closed)

Created:
4 years ago by fs
Modified:
4 years ago
Reviewers:
f(malita)
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unify "contributes to" and "requires mask" for clip-path child iteration Since contributesToClip(...) and requiresMask(...) have a lot of overlap, refactor them into a new (set of) function(s) that return an enumeration based on the requirements for the element in question. Committed: https://crrev.com/ce8c0ceacc0595d6fbc0ea52f07fd4b2132353ef Cr-Commit-Position: refs/heads/master@{#437248}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -36 lines) Patch
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp View 2 chunks +36 lines, -36 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
fs
This should be somewhere along the lines of your suggestion I think. Not less code, ...
4 years ago (2016-12-08 10:13:24 UTC) #7
f(malita)
On 2016/12/08 10:13:24, fs wrote: > This should be somewhere along the lines of your ...
4 years ago (2016-12-08 14:13:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563613002/1
4 years ago (2016-12-08 14:19:49 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 15:35:33 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-08 15:38:27 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce8c0ceacc0595d6fbc0ea52f07fd4b2132353ef
Cr-Commit-Position: refs/heads/master@{#437248}

Powered by Google App Engine
This is Rietveld 408576698