Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2096)

Unified Diff: content/browser/service_worker/embedded_worker_instance.cc

Issue 2563583002: Revert of ServiceWorker: Change DCHECK to CHECK for debugging process allocation (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/embedded_worker_instance.cc
diff --git a/content/browser/service_worker/embedded_worker_instance.cc b/content/browser/service_worker/embedded_worker_instance.cc
index dde5e053ad47d4748be7dc2f0715e6d2857a64fe..17246a1f1bc6c450541f893130461e1b9bffd0ef 100644
--- a/content/browser/service_worker/embedded_worker_instance.cc
+++ b/content/browser/service_worker/embedded_worker_instance.cc
@@ -577,9 +577,8 @@
void EmbeddedWorkerInstance::OnProcessAllocated(
std::unique_ptr<WorkerProcessHandle> handle,
ServiceWorkerMetrics::StartSituation start_situation) {
- // TODO(shimazu): Change CHECK to DCHECK after crbug.com/668633 is fixed.
- CHECK_EQ(EmbeddedWorkerStatus::STARTING, status_);
- CHECK(!process_handle_);
+ DCHECK_EQ(EmbeddedWorkerStatus::STARTING, status_);
+ DCHECK(!process_handle_);
process_handle_ = std::move(handle);
starting_phase_ = REGISTERING_TO_DEVTOOLS;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698