DevTools: Disallow console.log statements with eslint

third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackend.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 319 matching lines @@
 
     var messageObject = /** @type {!Object} */ ((typeof message === 'string') ? JSON.parse(message) : message);
 
     if ('id' in messageObject) {  // just a response for some request
       var callback = this._callbacks[messageObject.id];
       if (!callback) {
         InspectorBackendClass.reportProtocolError('Protocol Error: the message with wrong id', messageObject);
         return;
       }
 
-      var processingStartTime;
       if (InspectorBackendClass.Options.dumpInspectorTimeStats)
-        processingStartTime = Date.now();
+        console.time('time-stats: ' + callback.methodName);

[chenwilliam, 2016/12/08 20:00:23]

maybe extract the label for console.time into a const?

[einbinder, 2016/12/09 01:16:05]

Done.

 
       this._agent(callback.domain).dispatchResponse(messageObject, callback.methodName, callback);
       --this._pendingResponsesCount;
       delete this._callbacks[messageObject.id];
 
-      if (InspectorBackendClass.Options.dumpInspectorTimeStats) {
-        console.log(
-            'time-stats: ' + callback.methodName + ' = ' + (processingStartTime - callback.sendRequestTime) + ' + ' +
-            (Date.now() - processingStartTime));
-      }
+      if (InspectorBackendClass.Options.dumpInspectorTimeStats)
+        console.timeEnd('time-stats: ' + callback.methodName);
 
       if (this._scripts && !this._pendingResponsesCount)
         this._deprecatedRunAfterPendingDispatches();
     } else {
       if (!('method' in messageObject)) {
         InspectorBackendClass.reportProtocolError('Protocol Error: the message without method', messageObject);
         return;
       }
 
       var method = messageObject.method.split('.');
@@ skipping 46 matching lines @@
       this._scripts = [];
       for (var id = 0; id < scripts.length; ++id)
         scripts[id].call(this);
     }
   }
 
   /**
    * @param {string} message
    */
   _dumpProtocolMessage(message) {
-    console.log(message);
+    console.log(message);  // eslint-disable-line no-console
   }
 
   /**
    * @param {string} reason
    */
   _onDisconnect(reason) {
     this._connection = null;
     this._runPendingCallbacks();
     this.dispose();
   }
@@ skipping 276 matching lines @@
       return;
     }
 
     var params = [];
     if (messageObject.params) {
       var paramNames = this._eventArgs[messageObject.method];
       for (var i = 0; i < paramNames.length; ++i)
         params.push(messageObject.params[paramNames[i]]);
     }
 
-    var processingStartTime;
     if (InspectorBackendClass.Options.dumpInspectorTimeStats)
-      processingStartTime = Date.now();
+      console.time('time-stats: ' + messageObject.method);
 
     this._dispatcher[functionName].apply(this._dispatcher, params);
 
     if (InspectorBackendClass.Options.dumpInspectorTimeStats)
-      console.log('time-stats: ' + messageObject.method + ' = ' + (Date.now() - processingStartTime));
+      console.timeEnd('time-stats: ' + messageObject.method);
   }
 };
 
 InspectorBackendClass.Options = {
   dumpInspectorTimeStats: false,
   dumpInspectorProtocolMessages: false,
   suppressRequestErrors: false
 };