Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java

Issue 2563503002: [Downloads UI] Add histograms for file extensions (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java
index 4a58bc937d2e03f0deadd5c8c3324fa98216d712..43f99ff2c541938a78ff254bca69a6ba6dfce696 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java
@@ -110,7 +110,16 @@ public class DownloadHistoryAdapter extends DateDividedAdapter implements Downlo
for (DownloadItem item : result) {
DownloadItemWrapper wrapper = createDownloadItemWrapper(item);
- if (addDownloadHistoryItemWrapper(wrapper)) itemCounts[wrapper.getFilterType()]++;
+ if (addDownloadHistoryItemWrapper(wrapper)
+ && wrapper.isVisibleToUser(DownloadFilter.FILTER_ALL)) {
+ itemCounts[wrapper.getFilterType()]++;
+ if (!isOffTheRecord && wrapper.getFilterType() == DownloadFilter.FILTER_OTHER) {
+ RecordHistogram.recordEnumeratedHistogram(
+ "Android.DownloadManager.OtherExtensions.InitialCount",
+ wrapper.getFileExtensionType(),
+ DownloadHistoryItemWrapper.FILE_EXTENSION_BOUNDARY);
+ }
+ }
}
if (!isOffTheRecord) recordDownloadCountHistograms(itemCounts);

Powered by Google App Engine
This is Rietveld 408576698