Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2563483003: Document::updateHoverActiveState only cancel hover and active state when hitting native scrollbar (Closed)

Created:
4 years ago by bokan
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Document::updateHoverActiveState only cancel hover and active state when hitting native scrollbar This patch is change Document::updateHoverActiveState argument bool hitScrollbar to Scrollbar hitScrollbar and check hitScrollbar is native scrollbar. This patch can make `div:hover::-webkit-scrollbar-thumb` working correctly. BUG=667206 Review-Url: https://codereview.chromium.org/2523903002 Cr-Commit-Position: refs/heads/master@{#434298} (cherry picked from commit bb7a6b0e1d0b5ca9aab24b7e794dc1d1e81c25db) Committed: https://chromium.googlesource.com/chromium/src/+/ea3b2748f90de1afbca1477bf39a00642aba1268

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -11 lines) Patch
M third_party/WebKit/Source/core/dom/Document.h View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 3 chunks +9 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 2 chunks +55 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/web/tests/data/custom-scrollbar-hover.html View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
bokan
4 years ago (2016-12-08 15:39:35 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ea3b2748f90de1afbca1477bf39a00642aba1268.

Powered by Google App Engine
This is Rietveld 408576698