Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2563463002: Fuchsia: dart:io Processes (Closed)

Created:
4 years ago by zra
Modified:
4 years ago
Reviewers:
rmacnak, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fuchsia: dart:io Processes This change adds support for non-detached processes spawned with Process.run and Process.start (but not Process.runSync). R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/32e5ef787d2d8af3c9455cf19a5b24746a3181bb

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Add const #

Total comments: 6

Patch Set 4 : Address comments #

Patch Set 5 : Format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+664 lines, -12 lines) Patch
M runtime/bin/BUILD.gn View 1 2 3 4 3 chunks +12 lines, -0 lines 0 comments Download
M runtime/bin/fdutils_fuchsia.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/process_fuchsia.cc View 1 2 3 4 4 chunks +636 lines, -11 lines 0 comments Download
M runtime/bin/socket_fuchsia.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M runtime/tests/vm/dart/hello_fuchsia_test.dart View 1 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
zra
4 years ago (2016-12-09 07:39:33 UTC) #3
rmacnak
LGTM https://codereview.chromium.org/2563463002/diff/40001/runtime/bin/process_fuchsia.cc File runtime/bin/process_fuchsia.cc (right): https://codereview.chromium.org/2563463002/diff/40001/runtime/bin/process_fuchsia.cc#newcode69 runtime/bin/process_fuchsia.cc:69: intptr_t fd_; exit_pipe_fd_ https://codereview.chromium.org/2563463002/diff/40001/runtime/bin/process_fuchsia.cc#newcode198 runtime/bin/process_fuchsia.cc:198: MessageId id; id ...
4 years ago (2016-12-12 18:18:21 UTC) #4
zra
https://codereview.chromium.org/2563463002/diff/40001/runtime/bin/process_fuchsia.cc File runtime/bin/process_fuchsia.cc (right): https://codereview.chromium.org/2563463002/diff/40001/runtime/bin/process_fuchsia.cc#newcode69 runtime/bin/process_fuchsia.cc:69: intptr_t fd_; On 2016/12/12 18:18:20, rmacnak wrote: > exit_pipe_fd_ ...
4 years ago (2016-12-13 19:07:50 UTC) #5
zra
4 years ago (2016-12-13 19:09:59 UTC) #7
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
32e5ef787d2d8af3c9455cf19a5b24746a3181bb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698