Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2563443007: Reduce use of Compiler.closedWorld (Closed)

Created:
4 years ago by Johnni Winther
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reduce use of Compiler.closedWorld - in preparation for passing ClosedWorld directly between phases. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/415ba7948cc5cd62808f1c5b871660865720e047

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+738 lines, -784 lines) Patch
M pkg/compiler/lib/src/common/backend_api.dart View 2 chunks +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_visitor.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 4 chunks +5 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 5 chunks +8 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 5 chunks +13 lines, -77 lines 0 comments Download
M pkg/compiler/lib/src/native/ssa.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 69 chunks +99 lines, -107 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 29 chunks +40 lines, -40 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 11 chunks +22 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen_helpers.dart View 5 chunks +6 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/graph_builder.dart View 3 chunks +7 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/interceptor_simplifier.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart View 36 chunks +200 lines, -187 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 6 chunks +13 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_string_builder.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/locals_handler.dart View 13 chunks +16 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 7 chunks +95 lines, -128 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 44 chunks +76 lines, -71 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa_branch_builder.dart View 3 chunks +6 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa_tracer.dart View 3 chunks +14 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/ssa/type_builder.dart View 5 chunks +7 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/ssa/types_propagation.dart View 11 chunks +29 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/ssa/value_range_analyzer.dart View 19 chunks +30 lines, -27 lines 0 comments Download
M pkg/compiler/lib/src/types/masks.dart View 2 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years ago (2016-12-09 14:03:09 UTC) #2
Siggi Cherem (dart-lang)
lgtm!
4 years ago (2016-12-09 20:53:54 UTC) #3
Johnni Winther
4 years ago (2016-12-12 09:35:42 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
415ba7948cc5cd62808f1c5b871660865720e047 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698