components/sync/driver/proxy_data_type_controller.h - Issue 2563423005: [Sync] Move ConfigureDataTypes logic into DataTypeManagerImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/driver/proxy_data_type_controller.h

Issue 2563423005: [Sync] Move ConfigureDataTypes logic into DataTypeManagerImpl. (Closed)

Patch Set: Address comments. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/driver/proxy_data_type_controller.h

diff --git a/components/sync/driver/proxy_data_type_controller.h b/components/sync/driver/proxy_data_type_controller.h

index 670a33fce2af60ca226bd8771997115a615c9c23..ba8645ca36ef9e5a3fb30289af46160375c499ce 100644

--- a/components/sync/driver/proxy_data_type_controller.h

+++ b/components/sync/driver/proxy_data_type_controller.h

@@ -24,7 +24,8 @@ class ProxyDataTypeController : public DataTypeController {

// DataTypeController interface.

bool ShouldLoadModelBeforeConfigure() const override;

void LoadModels(const ModelLoadCallback& model_load_callback) override;

- void RegisterWithBackend(ModelTypeConfigurer* configurer) override;

+ void RegisterWithBackend(base::Callback<void(bool)> set_downloaded,

+ ModelTypeConfigurer* configurer) override;

void StartAssociating(const StartCallback& start_callback) override;

void Stop() override;

std::string name() const override;