Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: components/sync/driver/glue/sync_backend_host_impl.h

Issue 2563423005: [Sync] Move ConfigureDataTypes logic into DataTypeManagerImpl. (Closed)
Patch Set: Address comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/driver/glue/sync_backend_host_impl.h
diff --git a/components/sync/driver/glue/sync_backend_host_impl.h b/components/sync/driver/glue/sync_backend_host_impl.h
index 5836f50fba100bf0280d42d7c626764e5ac731ca..0f33a9dd13bd3928199555edb0cf0c280cf81d83 100644
--- a/components/sync/driver/glue/sync_backend_host_impl.h
+++ b/components/sync/driver/glue/sync_backend_host_impl.h
@@ -67,11 +67,7 @@ class SyncBackendHostImpl : public SyncEngine, public InvalidationHandler {
WARN_UNUSED_RESULT;
void StopSyncingForShutdown() override;
void Shutdown(ShutdownReason reason) override;
- ModelTypeSet ConfigureDataTypes(
- ConfigureReason reason,
- const DataTypeConfigStateMap& config_state_map,
- const base::Callback<void(ModelTypeSet, ModelTypeSet)>& ready_task,
- const base::Callback<void()>& retry_callback) override;
+ void ConfigureDataTypes(ConfigureParams params) override;
void ActivateDirectoryDataType(ModelType type,
ModelSafeGroup group,
ChangeProcessor* change_processor) override;
@@ -109,15 +105,6 @@ class SyncBackendHostImpl : public SyncEngine, public InvalidationHandler {
// The types and functions below are protected so that test
// subclasses can use them.
- // Request the syncer to reconfigure with the specfied params.
- // Virtual for testing.
- virtual void RequestConfigureSyncer(
- ConfigureReason reason,
- ModelTypeSet to_download,
- const ModelSafeRoutingInfo& routing_info,
- const base::Callback<void(ModelTypeSet, ModelTypeSet)>& ready_task,
- const base::Closure& retry_callback);
-
// Called when the syncer has finished performing a configuration.
void FinishConfigureDataTypesOnFrontendLoop(
const ModelTypeSet enabled_types,
« no previous file with comments | « components/sync/driver/glue/sync_backend_host_core.cc ('k') | components/sync/driver/glue/sync_backend_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698