Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: components/sync/driver/data_type_controller.h

Issue 2563423005: [Sync] Move ConfigureDataTypes logic into DataTypeManagerImpl. (Closed)
Patch Set: Address comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync/BUILD.gn ('k') | components/sync/driver/data_type_manager_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/driver/data_type_controller.h
diff --git a/components/sync/driver/data_type_controller.h b/components/sync/driver/data_type_controller.h
index 76d0c63b060af31ae1feeb17942e3ca35a2c7ac5..1973b84728d929da1300dab6a61ecca3ed04691c 100644
--- a/components/sync/driver/data_type_controller.h
+++ b/components/sync/driver/data_type_controller.h
@@ -100,9 +100,10 @@ class DataTypeController : public base::SupportsWeakPtr<DataTypeController> {
// Registers with sync backend if needed. This function is called by
// DataTypeManager before downloading initial data. Non-blocking types need to
- // pass activation context containing progress marker to sync backend before
- // initial download starts.
- virtual void RegisterWithBackend(ModelTypeConfigurer* configurer) = 0;
+ // pass activation context containing progress marker to sync backend and use
+ // |set_downloaded| to inform the manager whether their initial sync is done.
+ virtual void RegisterWithBackend(base::Callback<void(bool)> set_downloaded,
+ ModelTypeConfigurer* configurer) = 0;
// Will start a potentially asynchronous operation to perform the
// model association. Once the model association is done the callback will
« no previous file with comments | « components/sync/BUILD.gn ('k') | components/sync/driver/data_type_manager_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698