Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 25634008: Perf scripts: improves PrintPerfResult documentation. (Closed)

Created:
7 years, 2 months ago by bulach
Modified:
7 years, 2 months ago
Reviewers:
Dominik Grewe, rmcilroy
CC:
chromium-reviews
Visibility:
Public.

Description

Perf scripts: improves PrintPerfResult documentation. No functional changes, just add a bit more info about the parameters. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226827

Patch Set 1 #

Total comments: 2

Patch Set 2 : Link to file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M build/util/lib/common/perf_tests_results_helper.py View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
bulach
ptal
7 years, 2 months ago (2013-10-02 14:03:38 UTC) #1
Dominik Grewe
LGTM with one nit. Thanks! https://codereview.chromium.org/25634008/diff/1/build/util/lib/common/perf_tests_results_helper.py File build/util/lib/common/perf_tests_results_helper.py (right): https://codereview.chromium.org/25634008/diff/1/build/util/lib/common/perf_tests_results_helper.py#newcode96 build/util/lib/common/perf_tests_results_helper.py:96: http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/process_log_utils.py?view=log Do you want ...
7 years, 2 months ago (2013-10-02 14:11:59 UTC) #2
bulach
https://codereview.chromium.org/25634008/diff/1/build/util/lib/common/perf_tests_results_helper.py File build/util/lib/common/perf_tests_results_helper.py (right): https://codereview.chromium.org/25634008/diff/1/build/util/lib/common/perf_tests_results_helper.py#newcode96 build/util/lib/common/perf_tests_results_helper.py:96: http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/process_log_utils.py?view=log On 2013/10/02 14:11:59, Dominik Grewe wrote: > Do ...
7 years, 2 months ago (2013-10-02 16:50:04 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 2 months ago (2013-10-02 16:51:34 UTC) #4
bulach
let's see if ross' account is setup by now :) ptal
7 years, 2 months ago (2013-10-03 08:28:32 UTC) #5
rmcilroy
lgtm Fingers crossed ;)
7 years, 2 months ago (2013-10-03 08:56:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/25634008/5001
7 years, 2 months ago (2013-10-03 09:05:41 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-03 10:55:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/25634008/5001
7 years, 2 months ago (2013-10-03 17:20:03 UTC) #9
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-03 17:25:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/25634008/5001
7 years, 2 months ago (2013-10-03 19:53:45 UTC) #11
commit-bot: I haz the power
7 years, 2 months ago (2013-10-03 20:11:06 UTC) #12
Message was sent while issue was closed.
Change committed as 226827

Powered by Google App Engine
This is Rietveld 408576698