Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: appengine/findit/model/flake/master_flake_analysis.py

Issue 2563383002: [Findit] Flake Checker: Extract commit position and git hash and display to UI for each analyzed bu… (Closed)
Patch Set: Addressing comments + rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« appengine/findit/handlers/flake/check_flake.py ('K') | « appengine/findit/handlers/flake/test/check_flake_test.py ('k') | appengine/findit/templates/flake/result.html » ('j') | appengine/findit/templates/flake/result.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/model/flake/master_flake_analysis.py
diff --git a/appengine/findit/model/flake/master_flake_analysis.py b/appengine/findit/model/flake/master_flake_analysis.py
index 2adca1bb3cfb416f774864357b54e1485b0097f9..72b26f9a164c0bf7c8dffda6f01f2053fa14cbee 100644
--- a/appengine/findit/model/flake/master_flake_analysis.py
+++ b/appengine/findit/model/flake/master_flake_analysis.py
@@ -19,6 +19,10 @@ class DataPoint(ndb.Model):
build_number = ndb.IntegerProperty(indexed=False)
pass_rate = ndb.FloatProperty(indexed=False)
task_id = ndb.StringProperty(indexed=False)
+ commit_position = ndb.IntegerProperty(indexed=False)
+ git_hash = ndb.StringProperty(indexed=False)
+ previous_commit_position = ndb.IntegerProperty(indexed=False)
+ previous_git_hash = ndb.StringProperty(indexed=False)
stgao 2016/12/14 07:58:28 It is not clear what "previous" means here.
lijeffrey 2016/12/14 22:15:11 Done.
class MasterFlakeAnalysis(
« appengine/findit/handlers/flake/check_flake.py ('K') | « appengine/findit/handlers/flake/test/check_flake_test.py ('k') | appengine/findit/templates/flake/result.html » ('j') | appengine/findit/templates/flake/result.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698