[Findit] Flake Checker: Extract commit position and git hash and display to UI for each analyzed bu…

appengine/findit/templates/flake/result.html

Index: appengine/findit/templates/flake/result.html
diff --git a/appengine/findit/templates/flake/result.html b/appengine/findit/templates/flake/result.html
index 79bc345fbcfd057859d43a3396350ce404ca53e8..a4d5483d0d6177f477154b419e54db7bf450fa78 100644
--- a/appengine/findit/templates/flake/result.html
+++ b/appengine/findit/templates/flake/result.html
@@ -92,7 +92,9 @@
         if (rate < 0) {
           not_run_data.push([value[0], 100, value[2]]);

[stgao, 2016/12/12 20:05:18]

Here, we don't need it?
Better to be consistent though.

[lijeffrey, 2016/12/14 02:37:13]

Done.

         } else {
-          run_data.push([value[0], rate, value[2]]);
+          // run_data contains information about each point in the format:
+          // [build number, pass rate, swarming task url, commit position, git hash].
+          run_data.push([value[0], rate, value[2], value[3], value[4]]);
         }
       });
 
@@ -169,17 +171,23 @@
         var buildNumber = itemData[0];
         var passRate = itemData[1];
         var taskUrl = itemData[2];
+        var commitPosition = itemData[3];
+        var gitHash = itemData[4];
 
         var tooltipStr = 'Build #: <a href="https://build.chromium.org/p/' + findit.masterName + '/builders/' + findit.builderName + '/builds/' + buildNumber + '" target="_blank">' + buildNumber + '</a><br> Pass rate: ' + passRate + '%';
         if (taskUrl) {
           tooltipStr += '<br>Task: <a href="' + taskUrl +'" target="_blank">link</a>';
         }
 
+        if (commitPosition && gitHash) {
+          tooltipStr += '<br>Commit position: <a href="https://crrev.com/' + gitHash + '" "target="_blank">' + commitPosition + '</a>';
+        }
+
         $("#tooltip").html(tooltipStr).css({top: item.pageY + 5, left: item.pageX + 5}).show();
       }
 
       var dataPointSelected = false;
-      $("#flake-data").bind("plothover", function (event, pos, item) {
+      $("#flake-data").bind("plothover", function(event, pos, item) {
         if (dataPointSelected)
           return;  // A data point is selected due to a click.
 
@@ -189,7 +197,7 @@
           $("#tooltip").hide();
         }
       });
-      $("#flake-data").bind("plotclick", function (event, pos, item) {
+      $("#flake-data").bind("plotclick", function(event, pos, item) {
         if (item) {
           dataPointSelected = true;  // Set selected data point upon click.
           showTooltipForDataPoint(item);
@@ -237,8 +245,14 @@
     Error info: {{ error }}<br>
     {% endif %}
     {% if suspected_flake.build_number %}
-    Flakiness <b>started</b> in Build: <a href="https://build.chromium.org/p/{{ master_name }}/builders/{{ builder_name }}/builds/{{ suspected_flake.build_number }}" target="_blank" style="color:red;font-weight:bold">{{ suspected_flake.build_number }}</a>
+      Flakiness <b>started</b> in Build: <a href="https://build.chromium.org/p/{{ master_name }}/builders/{{ builder_name }}/builds/{{ suspected_flake.build_number }}" target="_blank" style="color:red;font-weight:bold">{{ suspected_flake.build_number }}</a>
     {% endif %}
+    {% if suspected_flake.commit_position and suspected_flake.git_hash %}
+      <br>
+      Suspected flake git commit position: <a href="https://crrev.com/{{ suspected_flake.git_hash }}" target="_blank">{{ suspected_flake.commit_position }}</a>

[stgao, 2016/12/12 20:05:18]

This looks misleading to users.

Instead, we could show the regression range as: (commit_position_of_previous
build, commit_position_of_this_build]

Be careful about the inclusion and exclusion.

[lijeffrey, 2016/12/14 02:37:13]

Done.

+      <br>
+    {% endif %}
+
   </div>
   <br>
   <div>