[Findit] Flake Checker: Extract commit position and git hash and display to UI for each analyzed bu…

appengine/findit/waterfall/test/buildbot_test.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from datetime import datetime
 import mock
 import os
 import unittest
 
 from libs.http.retry_http_client import RetryHttpClient
@@ skipping 271 matching lines @@
     build_file = os.path.join(
         os.path.dirname(__file__), 'data', 'running_build.json')
     with open(build_file, 'r') as f:
       build_data = f.read()
 
     master_name = 'a'
     builder_name = 'b'
     build_number = 632
     expected_build_start_time = datetime.utcfromtimestamp(1417470720.763887)
     expected_chromium_revision = '449cdbd05616de91fcf7e8b4282e300336d6d7c5'
+    expected_commit_position = 306253
     expected_completed = False
     expected_result = None
     expected_blame_list = [
         'f1e24ae21c95228522c24697dae474db5f26854b',
         'fae4955b2ae9cf68aa2a391a7640b1c3276656e8',
         '4ef763a9bb3dc53c7afccbcab9a1b0327b83681c',
         '89ef2ae2a6e2d21813c14471eb444c8651b46651',
         '58becfc708670659119ca72472d1d0882797f706',
         '1cc47034de564d0fd33a89c7d785a539b6c3a5a0',
         '87be98a1f687d430c4e1e1a5da04065067a4c1cc',
@@ skipping 76 matching lines @@
     ]
 
     build_info = buildbot.ExtractBuildInfo(
         master_name, builder_name, build_number, build_data)
 
     self.assertEqual(master_name, build_info.master_name)
     self.assertEqual(builder_name, build_info.builder_name)
     self.assertEqual(build_number, build_info.build_number)
     self.assertEqual(expected_build_start_time, build_info.build_start_time)
     self.assertEqual(expected_chromium_revision, build_info.chromium_revision)
+    self.assertEqual(expected_commit_position, build_info.commit_position)
     self.assertEqual(expected_completed, build_info.completed)
     self.assertEqual(expected_result, build_info.result)
     self.assertEqual(expected_blame_list, build_info.blame_list)
     self.assertEqual(expected_failed_steps, build_info.failed_steps)
     self.assertEqual(expected_passed_steps, build_info.passed_steps)
     self.assertEqual(expected_not_passed_steps, build_info.not_passed_steps)
 
   def testExtractBuildInfoOfCompletedBuild(self):
     build_file = os.path.join(
         os.path.dirname(__file__), 'data', 'completed_build.json')
     with open(build_file, 'r') as f:
       build_data = f.read()
 
     master_name = 'a'
     builder_name = 'b'
     build_number = 632
     expected_build_start_time = datetime.utcfromtimestamp(1417470720.763887)
     expected_chromium_revision = '449cdbd05616de91fcf7e8b4282e300336d6d7c5'
+    expected_commit_position = 306253
     expected_completed = True
     expected_result = None
     expected_blame_list = [
         '449cdbd05616de91fcf7e8b4282e300336d6d7c5'
     ]
     expected_failed_steps = [
         'net_unittests on Windows-XP-SP3'
     ]
     expected_passed_steps = [
         'browser_tests on Windows-XP-SP3'
     ]
     expected_not_passed_steps = [
         'steps',
         'net_unittests on Windows-XP-SP3',
     ]
 
     build_info = buildbot.ExtractBuildInfo(
         master_name, builder_name, build_number, build_data)
 
     self.assertEqual(master_name, build_info.master_name)
     self.assertEqual(builder_name, build_info.builder_name)
     self.assertEqual(build_number, build_info.build_number)
     self.assertEqual(expected_build_start_time, build_info.build_start_time)
     self.assertEqual(expected_chromium_revision, build_info.chromium_revision)
+    self.assertEqual(expected_commit_position, build_info.commit_position)
     self.assertEqual(expected_completed, build_info.completed)
     self.assertEqual(expected_result, build_info.result)
     self.assertEqual(expected_blame_list, build_info.blame_list)
     self.assertEqual(expected_failed_steps, build_info.failed_steps)
     self.assertEqual(expected_passed_steps, build_info.passed_steps)
     self.assertEqual(expected_not_passed_steps, build_info.not_passed_steps)
 
   def testExtractBuildInfoBlameList(self):
     build_file = os.path.join(
         os.path.dirname(__file__), 'data', 'blame_list_test.json')
     with open(build_file, 'r') as f:
       build_data = f.read()
 
     master_name = 'a'
     builder_name = 'b'
     build_number = 632
 
     expected_blame_list = [
         '449cdbd05616de91fcf7e8b4282e300336d6d7c5',
         '6addffac2601ab1083a55d085847d9bf8e66da02'
     ]
 
     build_info = buildbot.ExtractBuildInfo(
         master_name, builder_name, build_number, build_data)
 
     self.assertEqual(expected_blame_list, build_info.blame_list)
+
+  def testGetCommitPosition(self):
+    self.assertIsNone(buildbot._GetCommitPosition(None))
+    self.assertIsNone(buildbot._GetCommitPosition(''))
+    self.assertIsNone(buildbot._GetCommitPosition('not a commit position'))
+    self.assertEqual(
+        438538, buildbot._GetCommitPosition('refs/heads/master@{#438538}'))