Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc

Issue 2563343002: Remove extension_misc::IsImeMenuExtensionId. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc
diff --git a/chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc b/chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc
index 499240c160605e7c3ce8bc45845a76e0cce324a9..9cc1e276eb934eec857dc0d427c893bb8b57da22 100644
--- a/chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc
+++ b/chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc
@@ -53,9 +53,7 @@ void ExtensionLauncherContextMenu::Init() {
AddPinMenu();
- if (controller()->IsOpen(item().id) &&
- !extension_misc::IsImeMenuExtensionId(
- controller()->GetAppIDForShelfID(item().id))) {
+ if (controller()->IsOpen(item().id)) {
sky 2016/12/12 16:06:55 remove {}
Azure Wei 2016/12/13 11:20:47 Done.
AddItemWithStringId(MENU_CLOSE, IDS_LAUNCHER_CONTEXT_MENU_CLOSE);
}
@@ -96,9 +94,7 @@ void ExtensionLauncherContextMenu::Init() {
} else if (item().type == ash::TYPE_DIALOG) {
AddItemWithStringId(MENU_CLOSE, IDS_LAUNCHER_CONTEXT_MENU_CLOSE);
} else {
- if (controller()->IsOpen(item().id) &&
- !extension_misc::IsImeMenuExtensionId(
- controller()->GetAppIDForShelfID(item().id))) {
+ if (controller()->IsOpen(item().id)) {
sky 2016/12/12 16:06:55 remove {}
Azure Wei 2016/12/13 11:20:47 Done.
AddItemWithStringId(MENU_CLOSE, IDS_LAUNCHER_CONTEXT_MENU_CLOSE);
}
}

Powered by Google App Engine
This is Rietveld 408576698