Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 256333002: Revert of Implement argument validation for chrome.cast.channel.{open,send} (Closed)

Created:
6 years, 7 months ago by Michael Achenbach
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Revert of Implement argument validation for chrome.cast.channel.{open,send} (https://codereview.chromium.org/255443002/) Reason for revert: Causing leaks: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/2069 Original issue's description: > Implement argument validation for chrome.cast.channel.{open,send} > > TESTED=Unit test. Manually with Cast extension > BUG=331165 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266804 TBR=munjal@chromium.org,imcheng@chromium.org,mfoltz@chromium.org NOTREECHECKS=true NOTRY=true BUG=331165 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266833

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -144 lines) Patch
M chrome/browser/extensions/api/cast_channel/cast_channel_api.h View 3 chunks +4 lines, -14 lines 0 comments Download
M chrome/browser/extensions/api/cast_channel/cast_channel_api.cc View 3 chunks +6 lines, -33 lines 0 comments Download
M chrome/browser/extensions/api/cast_channel/cast_channel_api_unittest.cc View 2 chunks +15 lines, -97 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
Created Revert of Implement argument validation for chrome.cast.channel.{open,send}
6 years, 7 months ago (2014-04-29 10:47:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/machenbach@chromium.org/256333002/1
6 years, 7 months ago (2014-04-29 10:48:09 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 10:48:39 UTC) #3
Message was sent while issue was closed.
Change committed as 266833

Powered by Google App Engine
This is Rietveld 408576698