Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Unified Diff: components/reading_list/ios/reading_list_model_storage.h

Issue 2563303002: Fix crash when deleting ReadingListStore via ReadingListModelStorage*. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/reading_list/ios/reading_list_model_storage.h
diff --git a/components/reading_list/ios/reading_list_model_storage.h b/components/reading_list/ios/reading_list_model_storage.h
index a2ed7cc4186d74f2c98b6798fe157eb5e0d00e06..422abf04367c90b1f95949f37837e2595d8cff7d 100644
--- a/components/reading_list/ios/reading_list_model_storage.h
+++ b/components/reading_list/ios/reading_list_model_storage.h
@@ -7,6 +7,7 @@
#include <vector>
+#include "base/macros.h"
#include "components/reading_list/ios/reading_list_entry.h"
class ReadingListModel;
@@ -22,6 +23,9 @@ class ReadingListModelStorage {
public:
class ScopedBatchUpdate;
+ ReadingListModelStorage() {}
+ virtual ~ReadingListModelStorage() {}
+
// Sets the model the Storage is backing.
// This will trigger store initalization and load persistent entries.
virtual void SetReadingListModel(ReadingListModel* model,
@@ -48,8 +52,15 @@ class ReadingListModelStorage {
class ScopedBatchUpdate {
public:
+ ScopedBatchUpdate() {}
virtual ~ScopedBatchUpdate() {}
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(ScopedBatchUpdate);
};
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(ReadingListModelStorage);
};
#endif // COMPONENTS_READING_LIST_IOS_READING_LIST_MODEL_STORAGE_H_
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698