Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Side by Side Diff: media/ffmpeg/ffmpeg_regression_tests.cc

Issue 2563183002: Fix up missing timestamps in FFmpegDemuxer. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | media/filters/ffmpeg_demuxer.h » ('j') | media/filters/ffmpeg_demuxer.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Regression tests for FFmpeg. Test files can be found in the internal media 5 // Regression tests for FFmpeg. Test files can be found in the internal media
6 // test data directory: 6 // test data directory:
7 // 7 //
8 // https://chrome-internal.googlesource.com/chrome/data/media 8 // https://chrome-internal.googlesource.com/chrome/data/media
9 // 9 //
10 // Simply add the custom_dep below to your gclient and sync: 10 // Simply add the custom_dep below to your gclient and sync:
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 // TODO(tguilbert): update PIPELINE_ERROR_DECODE to 170 // TODO(tguilbert): update PIPELINE_ERROR_DECODE to
171 // AUDIO_RENDERER_ERROR_IMPLICIT_CONFIG_CHANGE once the status is created. 171 // AUDIO_RENDERER_ERROR_IMPLICIT_CONFIG_CHANGE once the status is created.
172 FFMPEG_TEST_CASE(Cr599625, 172 FFMPEG_TEST_CASE(Cr599625,
173 "security/599625.mp4", 173 "security/599625.mp4",
174 PIPELINE_OK, 174 PIPELINE_OK,
175 PIPELINE_ERROR_DECODE); 175 PIPELINE_ERROR_DECODE);
176 // TODO(liberato): before crbug.com/658440 was fixed, this would fail if run 176 // TODO(liberato): before crbug.com/658440 was fixed, this would fail if run
177 // twice under ASAN. If run once, then it doesn't. However, it still catches 177 // twice under ASAN. If run once, then it doesn't. However, it still catches
178 // issues in crbug.com/662118, so it's included anyway. 178 // issues in crbug.com/662118, so it's included anyway.
179 FFMPEG_TEST_CASE(Cr658440, "security/658440.flac", PIPELINE_OK, PIPELINE_OK); 179 FFMPEG_TEST_CASE(Cr658440, "security/658440.flac", PIPELINE_OK, PIPELINE_OK);
180 FFMPEG_TEST_CASE(Cr665305, 180 FFMPEG_TEST_CASE(Cr665305, "crbug665305.flac", PIPELINE_OK, PIPELINE_OK);
181 "crbug665305.flac",
182 PIPELINE_OK,
183 PIPELINE_ERROR_DECODE);
184 FFMPEG_TEST_CASE_SEEKING(Cr666770, 181 FFMPEG_TEST_CASE_SEEKING(Cr666770,
185 "security/666770.mp4", 182 "security/666770.mp4",
186 PIPELINE_OK, 183 PIPELINE_OK,
187 PIPELINE_OK, 184 PIPELINE_OK,
188 base::TimeDelta::FromSecondsD(0.0843)); 185 base::TimeDelta::FromSecondsD(0.0843));
189 FFMPEG_TEST_CASE(Cr666874, 186 FFMPEG_TEST_CASE(Cr666874,
190 "security/666874.mp3", 187 "security/666874.mp3",
191 DEMUXER_ERROR_COULD_NOT_OPEN, 188 DEMUXER_ERROR_COULD_NOT_OPEN,
192 DEMUXER_ERROR_COULD_NOT_OPEN); 189 DEMUXER_ERROR_COULD_NOT_OPEN);
193 FFMPEG_TEST_CASE(Cr667063, "security/667063.mp4", PIPELINE_OK, PIPELINE_OK); 190 FFMPEG_TEST_CASE(Cr667063, "security/667063.mp4", PIPELINE_OK, PIPELINE_OK);
(...skipping 203 matching lines...) Expand 10 before | Expand all | Expand 10 after
397 } 394 }
398 395
399 TEST_P(FlakyFFmpegRegressionTest, BasicPlayback) { 396 TEST_P(FlakyFFmpegRegressionTest, BasicPlayback) {
400 if (Start(GetParam().filename, kClockless) == PIPELINE_OK) { 397 if (Start(GetParam().filename, kClockless) == PIPELINE_OK) {
401 Play(); 398 Play();
402 WaitUntilEndedOrError(); 399 WaitUntilEndedOrError();
403 } 400 }
404 } 401 }
405 402
406 } // namespace media 403 } // namespace media
OLDNEW
« no previous file with comments | « no previous file | media/filters/ffmpeg_demuxer.h » ('j') | media/filters/ffmpeg_demuxer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698