Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5835)

Unified Diff: chrome/browser/resources/bluetooth_internals/bluetooth_internals.js

Issue 2563113002: bluetooth: Add tests for Sidebar in bluetooth internals browser test suite. (Closed)
Patch Set: Close sidebar in teardown, split sidebar open/close tests Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/bluetooth_internals/bluetooth_internals.js
diff --git a/chrome/browser/resources/bluetooth_internals/bluetooth_internals.js b/chrome/browser/resources/bluetooth_internals/bluetooth_internals.js
index ffbb26816ad215512599e63583d77c38bf9c420e..f15709c2216ec40a42db8882d9be92ad3cf5092c 100644
--- a/chrome/browser/resources/bluetooth_internals/bluetooth_internals.js
+++ b/chrome/browser/resources/bluetooth_internals/bluetooth_internals.js
@@ -10,6 +10,7 @@
// Expose for testing.
var adapterBroker = null;
var devices = null;
+var sidebarObj = null;
dpapad 2016/12/14 00:32:05 Nit: s/sidebarObj/sidebar Or is |sidebar| already
mbrunson 2016/12/14 02:34:35 |sidebar| is a module on the window object so I di
cr.define('bluetooth_internals', function() {
/** @const */ var DevicesPage = devices_page.DevicesPage;
@@ -109,9 +110,9 @@ cr.define('bluetooth_internals', function() {
}
function setupPages() {
- var sidebar = new window.sidebar.Sidebar($('sidebar'));
- $('menu-btn').addEventListener('click', function() { sidebar.open(); });
- PageManager.addObserver(sidebar);
+ sidebarObj = new window.sidebar.Sidebar($('sidebar'));
+ $('menu-btn').addEventListener('click', function() { sidebarObj.open(); });
+ PageManager.addObserver(sidebarObj);
PageManager.addObserver(new PageObserver());
devicesPage = new DevicesPage();

Powered by Google App Engine
This is Rietveld 408576698