bluetooth: Add tests for Sidebar in bluetooth internals browser test suite.

chrome/test/data/webui/bluetooth_internals_browsertest.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Tests for chrome://bluetooth-internals
  */
 
 /** @const {string} Path to source root. */
 var ROOT_PATH = '../../../../';
@@ skipping 209 matching lines @@
       address: "CC:CC:84:96:92:84",
       name: "CCC",
       name_for_display: "CCC",
     };
   },
 };
 
 TEST_F('BluetoothInternalsTest', 'Startup_BluetoothInternals', function() {
   var adapterFactory = null;
   var deviceTable = null;
+  var sidebarNode = null;
 
   var fakeDeviceInfo1 = this.fakeDeviceInfo1;
   var fakeDeviceInfo2 = this.fakeDeviceInfo2;
   var fakeDeviceInfo3 = this.fakeDeviceInfo3;
 
   // Before tests are run, make sure setup completes.
   var setupPromise = this.setupResolver.promise.then(function() {
     adapterFactory = this.adapterFactory;
   }.bind(this));
 
-
   suite('BluetoothInternalsUITest', function() {
     var EXPECTED_DEVICES = 2;
 
     suiteSetup(function() {
       return setupPromise.then(function() {
         return Promise.all([
           adapterFactory.whenCalled('getAdapter'),
           adapterFactory.adapter.proxy.whenCalled('getInfo'),
           adapterFactory.adapter.proxy.whenCalled('getDevices'),
           adapterFactory.adapter.proxy.whenCalled('setClient'),
         ]);
       });
     });
 
     setup(function() {
       deviceTable = document.querySelector('#devices table');
+      sidebarNode = document.querySelector('#sidebar');
       devices.splice(0, devices.length);
       adapterBroker.adapterClient_.deviceAdded(fakeDeviceInfo1());
       adapterBroker.adapterClient_.deviceAdded(fakeDeviceInfo2());
     });
 
     teardown(function() {
       adapterFactory.reset();

[ortuno, 2016/12/12 23:24:48]

I think you also want to reset the state of the sidebar.

[mbrunson, 2016/12/13 01:05:35]

Done.

     });
 
     /**
      * Updates device info and verifies the contents of the device table.
      * @param {!device_collection.DeviceInfo} deviceInfo
      */
     function changeDevice(deviceInfo) {
       var deviceRow = deviceTable.querySelector('#' + escapeDeviceAddress(
           deviceInfo.address));
       var nameForDisplayColumn = deviceRow.children[0];
@@ skipping 143 matching lines @@
       var newDeviceInfo2 = fakeDeviceInfo3();
       newDeviceInfo2.rssi = null;
       adapterBroker.adapterClient_.deviceChanged(newDeviceInfo2);
       expectEquals('-42', rssiColumn.textContent);
 
       var newDeviceInfo3 = fakeDeviceInfo3();
       newDeviceInfo3.rssi = {value: -17};
       adapterBroker.adapterClient_.deviceChanged(newDeviceInfo3);
       expectEquals('-17', rssiColumn.textContent);
     });
+
+    /* Sidebar Tests */
+    test('SidebarSetup', function() {
+      var sidebarItems = Array.from(
+          sidebarNode.querySelectorAll('.sidebar-content li'));
+
+      ['devices'].forEach(function(pageName) {
+        var foundItem = sidebarItems.find(function(item) {
+          return item.dataset.pageName === pageName;
+        });
+
+        expectTrue(!!foundItem);
+      });
+    });
+
+    test('SidebarOpenClose', function() {

[ortuno, 2016/12/12 23:24:48]

Would it make sense to split these? That way instead of having a big
SidebarOpenClose test you have:

Sidebar_DefaultState
Sidebar_OpenClose
Sidebar_OpenTwice
Sidebar_CloseTwice

[mbrunson, 2016/12/13 01:05:35]

Done.

+      // Sidebar should be closed by default.
+      expectFalse(sidebarNode.classList.contains('open'));
+
+      sidebarObj.open();
+      expectTrue(sidebarNode.classList.contains('open'));
+      sidebarObj.close();
+      expectFalse(sidebarNode.classList.contains('open'));
+
+      // Multiple calls to open shouldn't change the state.
+      sidebarObj.open();
+      sidebarObj.open();
+      expectTrue(sidebarNode.classList.contains('open'));
+
+      // Multiple calls to close shouldn't change the state.
+      sidebarObj.close();
+      sidebarObj.close();
+      expectFalse(sidebarNode.classList.contains('open'));
+    });
   });
 
   // Run all registered tests.
   mocha.run();
 });