Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2563103002: Switch variations http headers to only be reported over https. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 40766c3a99f44b89ca86f7ae3e17ce503d74397c..4d886fb5d5769bdf46188f438fa7825d3e57ed6a 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -70434,6 +70434,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="Variations.Headers.ShouldAppendResult"
+ enum="VariationsShouldAppendHeadersResult">
+ <owner>jwd@chromium.org</owner>
+ <summary>
+ The result of the check of whether to append Variations headers to a url.
+ </summary>
+</histogram>
+
<histogram name="Variations.LoadPermanentConsistencyCountryResult"
enum="VariationsPermanentConsistencyCountryResult">
<owner>sclittle@chromium.org</owner>
@@ -105418,6 +105426,12 @@ value.
<int value="11" label="Failed - Unsupported Seed Format"/>
</enum>
+<enum name="VariationsShouldAppendHeadersResult" type="int">
+ <int value="0" label="Rejected: Not a Google domain."/>
rkaplow 2016/12/12 18:25:06 nit, maybe not a valid Google domain. ? Since this
jwd 2016/12/12 19:23:08 Changed code, keeping this label as is.
+ <int value="1" label="Rejected: Google, but not https."/>
+ <int value="2" label="Should append headers."/>
+</enum>
+
<enum name="VaryType" type="int">
<int value="0" label="No Vary header present"/>
<int value="1" label="Vary:User-Agent"/>

Powered by Google App Engine
This is Rietveld 408576698