[DevTools] show warning if 'Set-Cookie' header length is > 4096 symbols

third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js

Index: third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
index d16da3703b25ac6a5953e0b0e9c5ee4f0019d1f2..02533b156bd97faa47cae87c2aaa69bc7a12def6 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
@@ -372,6 +372,13 @@ SDK.NetworkDispatcher = class {
     networkRequest.responseReceivedTime = time;
     networkRequest.setResourceType(Common.resourceTypes[resourceType]);
 
+    // net::ParsedCookie::kMaxCookieSize = 4096 (net/cookies/parsed_cookie.h)
+    if ('Set-Cookie' in response.headers && response.headers['Set-Cookie'].length > 4096) {
+      Common.console.warn(Common.UIString(
+          'Set-Cookie header is ignored for response from url: %s. Cookie length should be less then or equal to 4096 symbols.',

[allada, 2016/12/10 09:48:22]

I think we should rename symbols to "characters" or "bytes", I think netstack
does it's count in characters/bytes not symbols.

[allada, 2016/12/10 09:48:22]

nit: s/for/in/

[kozy, 2016/12/16 03:15:02]

Done.

[kozy, 2016/12/16 03:15:02]

Done.

+          response.url));
+    }
+
     this._updateNetworkRequestWithResponse(networkRequest, response);
 
     this._updateNetworkRequest(networkRequest);