[DevTools] show warning if 'Set-Cookie' header length is > 4096 symbols

third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 354 matching lines @@
       eventData.mimeType = response.mimeType;
       var lastModifiedHeader = response.headers['last-modified'];
       eventData.lastModified = lastModifiedHeader ? new Date(lastModifiedHeader) : null;
       this._manager.dispatchEventToListeners(SDK.NetworkManager.Events.RequestUpdateDropped, eventData);
       return;
     }
 
     networkRequest.responseReceivedTime = time;
     networkRequest.setResourceType(Common.resourceTypes[resourceType]);
 
+    // net::ParsedCookie::kMaxCookieSize = 4096 (net/cookies/parsed_cookie.h)
+    if ('Set-Cookie' in response.headers && response.headers['Set-Cookie'].length > 4096) {
+      Common.console.warn(Common.UIString(
+          'Set-Cookie header is ignored for response from url: %s. Cookie length should be less then or equal to 4096 symbols.',

[allada, 2016/12/10 09:48:22]

I think we should rename symbols to "characters" or "bytes", I think netstack
does it's count in characters/bytes not symbols.

[allada, 2016/12/10 09:48:22]

nit: s/for/in/

[kozy, 2016/12/16 03:15:02]

Done.

[kozy, 2016/12/16 03:15:02]

Done.

+          response.url));
+    }
+
     this._updateNetworkRequestWithResponse(networkRequest, response);
 
     this._updateNetworkRequest(networkRequest);
     this._manager.dispatchEventToListeners(SDK.NetworkManager.Events.ResponseReceived, networkRequest);
   }
 
   /**
    * @override
    * @param {!Protocol.Network.RequestId} requestId
    * @param {!Protocol.Network.Timestamp} time
@@ skipping 502 matching lines @@
 SDK.MultitargetNetworkManager.Events = {
   ConditionsChanged: Symbol('ConditionsChanged'),
   UserAgentChanged: Symbol('UserAgentChanged')
 };
 
 
 /**
  * @type {!SDK.MultitargetNetworkManager}
  */
 SDK.multitargetNetworkManager;