Issue 256303008: Propose adding dmazzoni to c/b/ui/views OWNERS for accessibility changes

Issue 256303008: Propose adding dmazzoni to c/b/ui/views OWNERS for accessibility changes (Closed)

Created:
6 years, 7 months ago by dmazzoni

Modified:
6 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Propose adding dmazzoni to c/b/ui/views OWNERS for accessibility changes BUG=none NOTRY=true

Patch Set 1 #

Total comments: 1

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/browser/ui/views/OWNERS	View		1 chunk	+4 lines, -0 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sky

How about making yourself an owner in c/b/ui/views/a11y? Are there changes often done that aren't ...

6 years, 7 months ago (2014-04-29 17:15:38 UTC) #2

tfarina

https://codereview.chromium.org/256303008/diff/1/chrome/browser/ui/views/OWNERS File chrome/browser/ui/views/OWNERS (right): https://codereview.chromium.org/256303008/diff/1/chrome/browser/ui/views/OWNERS#newcode8 chrome/browser/ui/views/OWNERS:8: dmazzoni@chromium.org can you restrict this to per-file?

6 years, 7 months ago (2014-04-29 17:15:39 UTC) #3

dmazzoni

On 2014/04/29 17:15:38, sky wrote: > How about making yourself an owner in c/b/ui/views/a11y? Are ...

6 years, 7 months ago (2014-04-29 17:30:42 UTC) #4

sky

6 years, 7 months ago (2014-04-29 19:11:54 UTC) #5

Yes, sorry, I meant creating  c/b/ui/views/a11y/OWNERS.

  -Scott

On Tue, Apr 29, 2014 at 10:30 AM,  <dmazzoni@chromium.org> wrote:
> On 2014/04/29 17:15:38, sky wrote:
>>
>> How about making yourself an owner in c/b/ui/views/a11y? Are there changes
>
> often
>>
>> done that aren't covered by that?
>
>
> You suggested making me an owner here, maybe you meant in c/b/ui/views/a11y
> in
> the first place? FWIW, View::GetAccessibleState is implemented 43 times in
> chrome/browser/ui/views - I could make or review changes to those without
> bothering you. Trust but verify?
>
> Otherwise, David already added a c/b/ui/views/a11y OWNERS file in this
> change -
> maybe just rubberstamp that change if you prefer that:
> https://codereview.chromium.org/246433012/
>
>
> https://codereview.chromium.org/256303008/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Expand Messages | Collapse Messages