Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2302)

Unified Diff: cc/input/layer_scroll_offset_delegate.h

Issue 256303006: Make LayerScrollOffsetDelegate updates consistent. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/native/aw_contents.cc ('k') | cc/layers/layer_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/input/layer_scroll_offset_delegate.h
diff --git a/cc/input/layer_scroll_offset_delegate.h b/cc/input/layer_scroll_offset_delegate.h
index 2da5f13befbd83739448f6e289a3f2b58e033ae7..ba11c3839ddcc4945a5922d49d34f2cbd03454a3 100644
--- a/cc/input/layer_scroll_offset_delegate.h
+++ b/cc/input/layer_scroll_offset_delegate.h
@@ -17,14 +17,6 @@ namespace cc {
// The LayerScrollOffsetDelegate is only used on the impl thread.
class LayerScrollOffsetDelegate {
public:
- // This is called by the compositor to notify the delegate what is the upper
- // total scroll offset bound.
- virtual void SetMaxScrollOffset(const gfx::Vector2dF& max_scroll_offset) = 0;
-
- // This is called by the compositor when the scroll offset of the layer would
- // have otherwise changed.
- virtual void SetTotalScrollOffset(const gfx::Vector2dF& new_value) = 0;
-
// This is called by the compositor to query the current scroll offset of the
// layer.
// There is no requirement that the return values of this method are
@@ -34,21 +26,25 @@ class LayerScrollOffsetDelegate {
// more than the value passed to the most recent SetMaxScrollOffset call.
virtual gfx::Vector2dF GetTotalScrollOffset() = 0;
+ // This is called by the compositor to notify the delegate of any change to
+ // the following parameters:
+ // |total_scroll_offset| current scroll offset of the root layer,
+ // |max_scroll_offset| total scroll offset upper bound for the root layer,
+ // |scrollable_size| root layer scrollable size,
+ // |page_scale_factor| current page scale,
+ // |min_page_scale_factor| page scale lower limit,
+ // |max_page_scale_factor| page scale upper limit.
+ virtual void UpdateRootLayerState(const gfx::Vector2dF& total_scroll_offset,
+ const gfx::Vector2dF& max_scroll_offset,
+ const gfx::SizeF& scrollable_size,
+ float page_scale_factor,
+ float min_page_scale_factor,
+ float max_page_scale_factor) = 0;
+
// This is called by the compositor to check whether a delegate-managed fling
// is active or not.
virtual bool IsExternalFlingActive() const = 0;
- // This is called by the compositor to notify the delegate what is the current
- // page scale factor and limits are.
- virtual void SetTotalPageScaleFactorAndLimits(
- float page_scale_factor,
- float min_page_scale_factor,
- float max_page_scale_factor) = 0;
-
- // This is called by the compositor to notify the delegate what is the layer's
- // scrollable size is.
- virtual void SetScrollableSize(const gfx::SizeF& scrollable_size) = 0;
-
protected:
LayerScrollOffsetDelegate() {}
virtual ~LayerScrollOffsetDelegate() {}
« no previous file with comments | « android_webview/native/aw_contents.cc ('k') | cc/layers/layer_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698