Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 256303003: gyp performance: Load detect_host_arch directly. (Closed)

Created:
6 years, 7 months ago by Daniel Bratell
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

gyp performance: Load detect_host_arch directly. We ran "python detect_host_arch.py" ~15 times from gyp. Run detect_host_arch.py directly from from within gyp for faster execution and since the path is no longer part of the command, the result will also be cached more often. The total gain is at best 0.3 seconds. For most people it will be less. BUG=362075 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275361

Patch Set 1 #

Total comments: 2

Patch Set 2 : detect_host_arch: Changed an argument name to _ #

Patch Set 3 : detect_host_arch: Rebased to newer master #

Patch Set 4 : binutils using the file as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -39 lines) Patch
M build/common.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + build/detect_host_arch.py View 1 2 chunks +7 lines, -2 lines 0 comments Download
D build/linux/detect_host_arch.py View 1 chunk +0 lines, -35 lines 0 comments Download
M third_party/binutils/download.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Daniel Bratell
Eh, a patch I had forgotten since I did gyp performance fixes. Well... Now it ...
6 years, 7 months ago (2014-05-26 14:00:20 UTC) #1
Nico
lgtm I thought gn used build/linux/detect_host_arch.py , but apparently no longer https://codereview.chromium.org/256303003/diff/1/build/detect_host_arch.py File build/detect_host_arch.py (right): ...
6 years, 7 months ago (2014-05-27 08:28:56 UTC) #2
Daniel Bratell
https://codereview.chromium.org/256303003/diff/1/build/detect_host_arch.py File build/detect_host_arch.py (right): https://codereview.chromium.org/256303003/diff/1/build/detect_host_arch.py#newcode17 build/detect_host_arch.py:17: def DoMain(args): On 2014/05/27 08:28:56, Nico (away) wrote: > ...
6 years, 6 months ago (2014-06-05 07:11:51 UTC) #3
Daniel Bratell
The CQ bit was checked by bratell@opera.com
6 years, 6 months ago (2014-06-05 07:11:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bratell@opera.com/256303003/40001
6 years, 6 months ago (2014-06-05 07:13:02 UTC) #5
Daniel Bratell
thestig, mithro, can you please take a look at the path change in binutil's download ...
6 years, 6 months ago (2014-06-05 08:48:23 UTC) #6
Lei Zhang
lgtm
6 years, 6 months ago (2014-06-05 19:08:31 UTC) #7
mithro-old
lgtm
6 years, 6 months ago (2014-06-06 02:00:17 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 09:56:46 UTC) #9
Message was sent while issue was closed.
Change committed as 275361

Powered by Google App Engine
This is Rietveld 408576698