Fix DCHECK failure in extension_updater when scheduling first check

chrome/browser/extensions/updater/extension_updater_unittest.cc

Index: chrome/browser/extensions/updater/extension_updater_unittest.cc
diff --git a/chrome/browser/extensions/updater/extension_updater_unittest.cc b/chrome/browser/extensions/updater/extension_updater_unittest.cc
index 09858072061cf73f5d6584d538bd70eb5d0ef5d3..65fadc54e2db0fcf20255750e3b0a18df8518fa3 100644
--- a/chrome/browser/extensions/updater/extension_updater_unittest.cc
+++ b/chrome/browser/extensions/updater/extension_updater_unittest.cc
@@ -57,10 +57,12 @@
 #include "extensions/browser/extension_prefs.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_system.h"
+#include "extensions/browser/pref_names.h"
 #include "extensions/browser/updater/extension_downloader.h"
 #include "extensions/browser/updater/extension_downloader_delegate.h"
 #include "extensions/browser/updater/manifest_fetch_data.h"
 #include "extensions/browser/updater/request_queue_impl.h"
+#include "extensions/common/constants.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/extension_urls.h"
 #include "extensions/common/manifest_constants.h"
@@ -2259,6 +2261,22 @@ TEST_F(ExtensionUpdaterTest, TestUninstallWhileUpdateCheck) {
   ASSERT_FALSE(service.GetExtensionById(id, false));
 }
 
+// Tests that we don't get a DCHECK failure when the next check time saved in
+// prefs happens to be within one second of startup.
+TEST_F(ExtensionUpdaterTest, TestPersistedNextCheckTime) {
+  base::Time next_check_time =
+      base::Time::Now() + base::TimeDelta::FromMilliseconds(500);
+  prefs_->pref_service()->SetInt64(pref_names::kNextUpdateCheck,
+                                   next_check_time.ToInternalValue());
+  ServiceForManifestTests service(prefs_.get());
+  ExtensionUpdater updater(&service, service.extension_prefs(),
+                           service.pref_service(), service.profile(),
+                           kDefaultUpdateFrequencySeconds, NULL,

[lazyboy, 2016/12/10 00:10:15]

nit: nullptr

[asargent_no_longer_on_chrome, 2016/12/14 23:01:19]

Done.

+                           service.GetDownloaderFactory());
+  updater.Start();
+  updater.Stop();
+}
+
 // TODO(asargent) - (http://crbug.com/12780) add tests for:
 // -prodversionmin (shouldn't update if browser version too old)
 // -manifests & updates arriving out of order / interleaved