Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: third_party/WebKit/Source/core/frame/csp/MediaListDirectiveTest.cpp

Issue 2562953002: Part 5.2: Is policy list subsumed under subsuming policy? (Closed)
Patch Set: More test cases, removing .get() on members Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/csp/MediaListDirectiveTest.cpp
diff --git a/third_party/WebKit/Source/core/frame/csp/MediaListDirectiveTest.cpp b/third_party/WebKit/Source/core/frame/csp/MediaListDirectiveTest.cpp
index c5939fb4d4c62d387a1b85b2546adff13f353d5f..16b7565d713822b8354fe0e4c124ff1c4d3a98b9 100644
--- a/third_party/WebKit/Source/core/frame/csp/MediaListDirectiveTest.cpp
+++ b/third_party/WebKit/Source/core/frame/csp/MediaListDirectiveTest.cpp
@@ -135,12 +135,11 @@ TEST_F(MediaListDirectiveTest, Subsumes) {
};
MediaListDirective emptyA("plugin-types", "", csp.get());
- EXPECT_TRUE(emptyA.subsumes({&emptyA}));
for (const auto& test : cases) {
- std::vector<MediaListDirective*> policiesB;
+ HeapVector<Member<MediaListDirective>> policiesB;
for (const auto& policy : test.policiesB) {
- policiesB.push_back(
+ policiesB.append(
new MediaListDirective("plugin-types", policy, csp.get()));
}

Powered by Google App Engine
This is Rietveld 408576698